This patch exports CMake library targets in the namespace Bullet to enable target-based linking.
rickertm on pull request #1303
The new approach lets projects ship a config with their installation that can be used by other projects without supplying the find script.
There is some error on Windows that I need to check out, hence the revert
Erwin Coumans
@erwincoumans Could the revert be reverted? This would help people using CMake’s ExternalProject or FetchContent that want to just include the target.
Dwarfius
This pr consist of the cmake reformatting
madebr on pull request #2643
This PR looks solid and makes Bullet usable with CMake.
eliasdaler
P.S. It will also be nice to add aliases for targets as was done in #1303 which was reverted, unfortunately.
Bullet is a great library, it deserves up to date build system. I hope this initiative moves forward
helynranta
I agree the build system and the code base should be improved, but we lack resources to work on this and rather keep it as-is.
Erwin Coumans
Let me get this right…
I made a C++ project, decided to use CMake as my build system, but didn’t want to learn or keep up with CMake, so I’d prefer to just let it bit rot instead.
Fantastic. /endsarcasm
I guess I’m carrying a massive CMakeLists.txt patch in Heresy’s source tree.
Is this really lacking the resources or is it lacking the humility to trust other developers to make sane decisions?
There are a lot of changes and I will need to review each of them, not sure if/when I get to this.
Erwin Coumans
Leave a Reply